Update refs to connectrpc #539
Conversation
smaye81
requested review from
Alfus,
jhump,
timostamm and
akshayjshah
and removed request for
Alfus and
jhump
README.md
Outdated
| @@ -1,11 +1,12 @@ | |||
| # connect-crosstest | |||
| # connect-conformance | |||
There was a problem hiding this comment.
Just conformance seems more straight-forward to me.
There was a problem hiding this comment.
Should this be lowercase conformance? Also, on line 9 then should it say
conformanceruns a suite of cross-compatibility...
Kinda sounds weird to me but if you guys are fine with it, works for me.
There was a problem hiding this comment.
The sentence sounds weird to me too, but couldn't you simply use "This repository runs..." to avoid it?
.github/CONTRIBUTING.md
Outdated
| @@ -40,7 +40,7 @@ make | |||
| Start by creating a new branch for your changes: | |||
|
|
|||
| ``` | |||
| cd $GOPATH/src/github.com/bufbuild/connect-crosstest | |||
| cd $GOPATH/src/github.com/connectrpc/conformance | |||
There was a problem hiding this comment.
Think this file needs to be updated more carefully - wherever we're using the import path (for example, when cloning into GOPATH), we should use connectrpc.com/conformance.
There was a problem hiding this comment.
Thanks Akshay. I assume this also goes for the actual module name itself in go.mod right? Also, should it apply to the links at the bottom?
There was a problem hiding this comment.
It applies to go.mod, because that's the import path. The links below are to Github, though, so they should be github.com/connectrpc/conformance.
There was a problem hiding this comment.
Got it. Updated. Let me know what you think.
This updates the repo to reference
connectrpc/conformanceinstead ofbufbuild/connect-crosstest. All references to 'crosstests' have been renamed to 'conformance' or 'conformance tests' where applicable.Note the README titles the repo as
connect-conformance.Not intended to merge until the repo itself is moved to the
connectrpcorganization.